prompt-toolkit / prompt-toolkit/python-prompt-toolkit

style property of FloatContainer does not apply to the text in CompletetionsMenu

Open
#1,580 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

Adding a style attribute to change the color of the text given in a CompletionsMenu embedded in the floats list of a FloatContainer does not work.

This issue can be reproduced by adding style="red italic bold" to the following sample, as shown below:
python-prompt-toolkit/examples/full-screen/simple-demos/autocompletion.py:


body = FloatContainer(
    content=HSplit(
        [
            Window(
                FormattedTextControl('Press "q" to quit.'), height=1, style="reverse"
            ),
            Window(BufferControl(buffer=buff)),
        ]
    ),
    floats=[
        Float(
            xcursor=True,
            ycursor=True,
            content=CompletionsMenu(max_height=16, scroll_offset=1),
        ),
    ],
    style="red italic bold"
)

Output:
Screen Shot 2022-03-04 at 6 53 48 PM

You can see that text in the completions menu is bold and italic, but not red. So, while all other styles are picked by the completions menu but not the text color.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with python-prompt-toolkit/examples/full-screen/simple-demos/autocompletion.py and reproduce the issue by adding style="red italic bold" to the FloatContainer. Trace how FloatContainer and CompletionsMenu apply styles, then verify that the completions text also receives the color while retaining the bold and italic styles.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.