prompt-toolkit / prompt-toolkit/python-prompt-toolkit

Broken completion with diacritics

Open
#1,448 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

Working

Take the following code

import prompt_toolkit.completion
comp = prompt_toolkit.completion.WordCompleter(["foo", "bar"])
prompt_toolkit.prompt(completer=comp)

Test it

  • press f
  • prompt_toolkit suggests foo -> good
  • press o
  • prompt_toolkit still suggests foo -> good

Not working

Take the following code

import prompt_toolkit.completion
comp = prompt_toolkit.completion.WordCompleter(["aézzz", "éxxx", "bar", "xfail"])
prompt_toolkit.prompt(completer=comp)

Test it

  • press a
  • prompt_toolkit suggests aézzz -> good
  • press é
  • prompt_toolkit suggests éxxx -> wrong
  • press z
  • prompt_toolkit does not suggest anything -> wrong
  • tab does not complete -> wrong

Try again

  • press a
  • prompt_toolkit suggests aézzz -> good
  • press é
  • prompt_toolkit suggests éxxx -> wrong
  • press x
  • prompt_toolkit suggests xfail -> wrong

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the two prompt_toolkit completion snippets and compare the behavior after each listed keystroke. The fix is done when completion keeps the expected diacritic-containing word selected and typing further characters or pressing Tab completes it correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.