prompt-toolkit / prompt-toolkit/python-prompt-toolkit

Allow `sentence=True` in NestedCompleter

Open
#1,400 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
815
PR merge metrics
No merged PRs in 30d

Description

Given a complete dict like

{ 'a': { 'b.c.d' } }

for NestedCompleter does not allow completing after typing a b., because the WordCompleter for b. doesn't use sentence=True.

Is it possible to have sentence=True as a default or a configuration option?

https://github.com/prompt-toolkit/python-prompt-toolkit/blob/b76946c3d046dfa0a00fee6c393ba1c936f5a435/prompt_toolkit/completion/nested.py#L106

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read prompt_toolkit/completion/nested.py at the referenced NestedCompleter implementation, focusing on how its WordCompleter is constructed. Trace how the completer handles the example a b. input and determine how a sentence=True default or configuration option should be represented. Done means completing after a b. works for the shown nested dictionary.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.