prompt-toolkit / prompt-toolkit/python-prompt-toolkit
extra control sequence with 0585d1199a739a8cff9d4e976f2f1f7dce883fe8 ?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
I have a project which test suite fails since above commit as there are extra control sequences that are sent since above commit, in particular I'm expecting for IPython prompt, which fails, the only difference I can see is the following from pytest fail report:
Pre 0585d1199a739a8cff9d4e976f2f1f7dce883fe8 (test pass, but if I force fail them I get from prompt toolkit subprocess:
last 100 chars: b'\x1b[22;0t\x1b]0;IPython: dev/pyflyby\x07\nIn [1]: '
Post 0585d1199a739a8cff9d4e976f2f1f7dce883fe8
last 100 chars: b'\x1b[22;0t\x1b]0;IPython: dev/pyflyby\x07\nIn [1]:\x1b[7D\x1b[8C'
now I'll find a way to fix the test and strip that out; but I just want to make sure this is/was purposeful.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare prompt-toolkit behavior before and after commit 0585d1199a739a8cff9d4e976f2f1f7dce883fe8, starting from the pytest failure report and the shown IPython prompt output. Determine whether the added \u001b[7D\u001b[8C control sequences are intentional; done means their purpose is established and the affected test behavior is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100