prompt-toolkit / prompt-toolkit/python-prompt-toolkit
Support for Mixed-case in Style Tags ?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 815
- PR merge metrics
- No merged PRs in 30d
Description
Would it be possible to update line 170:
CLASS_NAMES_RE = re.compile(r"^[a-z0-9.\s_-]*$") # This one can't contain a comma!
in:
https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/prompt_toolkit/styles/style.py
to support lower and UPPER case letters?
I like to create style tag names that use upper case letters for colors (R for Red, G for Green, etc.)
Thanks,
/jim
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open prompt_toolkit/styles/style.py and inspect line 170, where CLASS_NAMES_RE is defined. Confirm how style tag names are validated, then update the accepted characters so uppercase letters are supported alongside the existing names; done means style tags using uppercase color letters are accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100