prometheus / prometheus/prometheus
align retention.size format with IEC units
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 66.1k
- Forks
- 10.8k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 131
Description
It is now not possible to specify 5G or 5Gi, but we have to provide 5GB. This seems like an arbitrary decision to not adopt the k8s standard, but I am probably unaware of limitations in this matter. (Like, is it not possible to use i (as in Gi) to round to thousands?)
Proposal
Use case. Why is this important?
To not have to learn multiple formats.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the retention.size configuration parsing entry point and any tests for storage-size formats. Review which suffixes are currently accepted and how the requested G and Gi forms should relate to existing units. Done means the supported format is documented by tests and the retention.size configuration accepts the agreed IEC-compatible forms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, observability-sre
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100