prometheus / prometheus/prometheus

tsdb benchmarks: create consistent way for periodic commits

Open
#15,872 2 comments 0 reactions 1 assignee View on GitHub

@RaphSku is already working on this.

Since Dec 16, 2025.

benchmark component/tsdb help wanted priority/P3
Dominant language
Go
Stars
66.1k
Forks
10.8k
Avg merge
2d 1h
Merged PRs (30d)
131

Description

Just out of interest: In createHeadForBenchmarkSelect you added a commit every 1000 appends, here 100k*c appends are done. Is there a technical reason?
No reason; I probably copied the 1000 from somewhere but can't find it now.
There are many different styles, some of which look like errors, e.g. here.
I agree it should be consistent but probably am not going to fix that today.

Originally posted by @bboreham in https://github.com/prometheus/prometheus/pull/15732#discussion_r1904380287

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.