prometheus / prometheus/procfs
Make net tcp/udp read limit configurable
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 883
- Forks
- 388
- Avg merge
- 13h 28m
- Merged PRs (30d)
- 3
Description
Right now the readLimit is a const 4GiB.
For use in the node_exporter, it would be useful to allow a max limit of the read size to avoid allocating too much memory when a system is already under heavy load.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the readLimit constant and the code that reads the net/tcp and net/udp proc files. Check how those read paths are used by node_exporter and determine an appropriate configurable maximum that avoids excessive allocation. Done means callers can set the limit and the default preserves the current behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100