prometheus / prometheus/node_exporter

Improve end-to-end tests

Open
#478 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accepted enhancement help wanted
Dominant language
Go
Stars
13.8k
Forks
2.7k
Avg merge
1d 23h
Merged PRs (30d)
8

Description

The end-to-end tests currently only work under Linux, but we should also test all other collectors for other OSes. Instead of comparing the output to one single golden template, each collector probably needs their own file.

Rewriting the end-to-end tests to Go will probably make things easier.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing end-to-end tests, collectors, and single golden template to identify the Linux-only assumptions. Done means other collectors are tested on their relevant operating systems, each collector has its own expected-output file, and the end-to-end tests are rewritten in Go.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
operating-systems, testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.