prometheus / prometheus/node_exporter
[BUG] No Custom Paths for EDAC scraping
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.8k
- Forks
- 2.7k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 8
Description
I noticed that the edac scraping in node-exporter is hard coded to a path.
var (
edacMemControllerRE = regexp.MustCompile(`.*devices/system/edac/mc/mc([0-9]*)`)
edacMemCsrowRE = regexp.MustCompile(`.*devices/system/edac/mc/mc[0-9]*/csrow([0-9]*)`)
)
from this file. I believe this is a bug/oversight as we can set the actual sysfs with args, but not the path that the edac is scraped from.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with collector/edac_linux.go and compare its hard-coded EDAC paths with the existing sysfs argument handling. Trace how custom sysfs paths are configured, then define how the EDAC scrape path should be supplied and verify that scraping uses it instead of the fixed path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100