prometheus / prometheus/node_exporter

Add a new way to filter mount points

Open
#3,380 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.8k
Forks
2.7k
Avg merge
1d 23h
Merged PRs (30d)
8

Description

This is a enhancement proposal to add a new way to filter mount points.

Our current use case is that we collect node_filesystem_avail_bytes metric  filtered by certain prefix on the mount point paths. However, if there are any inconsistencies in the naming, it can lead into difficulties to track all the wanted mount points.

I am proposing two alternative new ways filter mount points:

  1. Add a way for node-exporter to read file system UUIDs so that then the mount point filtering could be done based on the UUID. This would be the preferred option because the UUID is supposed to be unique and works well with LVMs and regular disks alike.

  2. Add a way for node-exporter to read file system labels so that then the mount point filtering could be done based on the label.

Do you think implementing one of these would be possible and which one you would prefer? If it would be possible, I would propose extending the filesystemCollector to include one of these filters.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the filesystemCollector and its current mount-point filtering for the node_filesystem_avail_bytes metric. The proposal needs a decision between UUID- and label-based filtering before implementation; done would mean the chosen filesystem identity can be used to filter mount points.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability-sre, operating-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.