prometheus / prometheus/node_exporter
RFE: Support all Linux kernel NFSv4 client and server RPC operations
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.8k
- Forks
- 2.7k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 8
Description
Currently, node_exporter has incomplete support for NFSv4 RPC operation statistics for both NFS clients and NFS servers, which is (partly) due to prometheus/procfs not supporting them (filed as prometheus/procfs#699). Supporting an expanded procfs NFS v4 operations list would probably take some restructuring of some code; updateNFSdRequestsv4Stats (in collectors/nfsd_linux.go) might not want to have to list all of the fields by hand and so might switch to the reflect-based approach used in the NFS client metrics code (although I don't know if the field names are completely compatible).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with prometheus/procfs#699 and collectors/nfsd_linux.go, especially updateNFSdRequestsv4Stats; compare its manually listed server fields with the reflect-based NFS client metrics code. Confirm whether the field names are compatible and determine the required restructuring. Done means node_exporter supports the expanded Linux NFSv4 client and server RPC operation statistics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100