prometheus / prometheus/node_exporter

Feat: expose per-dataset metrics in the ZFS collector on FreeBSD

Open
#2,693 7 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.8k
Forks
2.7k
Avg merge
1d 23h
Merged PRs (30d)
8

Description

Host operating system: output of uname -a

FreeBSD, all versions

node_exporter version: output of node_exporter --version

1.5.0

Feature

PR #1632 exposed ZFS's per-dataset performance metrics, but only on Linux. The same metrics are available on FreeBSD. However, whereas on Linux they are presented as files in /proc , on FreeBSD they are presented as sysctls. The ZFS collector already publishes non-dataset-specific metrics on FreeBSD, so I would think that it shouldn't be too hard to add the dataset-specific ones too. See https://github.com/asomers/ztop/blob/master/src/app.rs for an example (in Rust) of a project that parses both Linux's and FreeBSD's ZFS per-dataset metrics.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing ZFS collector and its FreeBSD handling, then compare the Linux per-dataset metric parsing with the FreeBSD sysctl layout. Use the ztop example as a reference for parsing both platforms. Done means the collector publishes the corresponding per-dataset metrics on FreeBSD.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.