prometheus / prometheus/node_exporter

[Feature request] Add sensor label to node_hwmon_temp_celsius

Open
#2,664 7 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.8k
Forks
2.7k
Avg merge
1d 23h
Merged PRs (30d)
8

Description

When I add node_hwmon_temp_celsius to a dashboard, I found that it is very hard to map those metrics to the corresponding physical devices.

There are only chip names and sensor names, and sensor names always show as "temp%d".

node_hwmon_temp

It seems the label label in node_hwmon_sensor_label is more "human readable".

Is it possible to also add the label into node_hwmon_temp_celsius?

An expected example:

node_hwmon_temp_celsius{chip="pci0000:00_0000:00:18_3", label="tdie", sensor="temp1"}
node_hwmon_temp_celsius{chip="pci0000:00_0000:00:18_3", label="tctl", sensor="temp2"}
node_hwmon_temp_celsius{chip="pci0000:00_0000:00:18_3", label="tccd1", sensor="temp3"}
node_hwmon_temp_celsius{chip="pci0000:00_0000:00:18_3", label="tccd2", sensor="temp4"}

And maybe we can remove node_hwmon_sensor_label as a metric after adding the label to node_hwmon_temp_celsius.
Will the label of a sensor change over time?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing where node_hwmon_temp_celsius and node_hwmon_sensor_label are emitted and how their labels are populated. Determine whether sensor labels can change and whether node_hwmon_sensor_label should remain for compatibility. Done means the requested label behavior and metric-removal decision are resolved, implemented, and covered by the relevant collector tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, prometheus
Domain
observability-sre
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.