prometheus / prometheus/node_exporter
make error
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.8k
- Forks
- 2.7k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 8
Description
Host operating system: output of uname -a
[root@localhost node_exporter]# uname -a
Linux localhost.localdomain 4.19.90-2108.8.0.0106.up4.uel20.aarch64 #1 SMP Wed Oct 27 17:45:50 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
[root@localhost node_exporter]#
node_exporter version: output of node_exporter --version
master
node_exporter command line flags
[root@localhost node_exporter]# ./checkmetrics.sh /root/go/bin/promtool collector/fixtures/e2e-64k-page-output.txt
Some Prometheus metrics do not follow best practices:
error while linting: text format parsing error in line 2846: second HELP line for metric name "node_xfs_read_calls_total"
[root@localhost node_exporter]#
Are you running node_exporter in Docker?
no
What did you do that produced an error?
When I execute make, after protmtool exists, the $(PROMTOOL) target reports an error
What did you expect to see?
no error
What did you see instead?
[root@localhost node_exporter]# make
...
...
vetting code
GO111MODULE=on go vet ./...
checking metrics for correctness
./checkmetrics.sh /root/go/bin/promtool collector/fixtures/e2e-64k-page-output.txt
Some Prometheus metrics do not follow best practices:
error while linting: text format parsing error in line 2846: second HELP line for metric name "node_xfs_read_calls_total"
make: *** [Makefile:125:checkmetrics] 错误 1
[root@localhost node_exporter]#
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the checkmetrics target in Makefile and the reported line in collector/fixtures/e2e-64k-page-output.txt. Inspect the node_xfs_read_calls_total entries around line 2846 and run make to confirm that metric checking completes without the duplicate HELP error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100