prometheus / prometheus/node_exporter

Diskstats collection negation regex not working

Open
#2,241 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.8k
Forks
2.7k
Avg merge
1d 23h
Merged PRs (30d)
8

Description

Host operating system: output of uname -a

Linux

node_exporter version: output of node_exporter --version

0.16.0

node_exporter command line flags

--collector.diskstats.ignored-devices

Are you running node_exporter in Docker?

No

What did you do that produced an error?

I am trying to collect diskstats using node_exporter. Currently there are multiple devices on the machine. I only want to collect the stats of devices with a particular naming pattern. The issue here is that the naming convention for the other devices that i don't want stats to be collected for is not known. Is there any other way to do so?
Or is there a plan to include a flag for device inclusion instead of ignored devices?

What did you expect to see?
What did you see instead?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the diskstats collection behavior with the reported ignored-devices flag and inspect the diskstats collector's regex handling. The issue does not provide the regex, expected output, observed output, or named files and tests; done would require a reproducible pattern-matching behavior and a verified fix or documented limitation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.