prometheus / prometheus/node_exporter

Feature adjustment --rootfs.path

Open
#1,889 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.8k
Forks
2.7k
Avg merge
1d 23h
Merged PRs (30d)
8

Description

--rootfs.path ONLY filters filesystem metrics IF the given path is a mount. Thats rather limiting.. I f.ex. use node_exporter as a sidecar to monitor disk usage on PVs on containers - so I mount in the PVs to /mnt/$pv-name - and would like to filter metrics to ONLY get for the ones mounted under /mnt..
That works if /mnt itself is a mount - but otherwise all metrics is just removed ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the --rootfs.path filesystem-metrics filtering behavior described in the issue and trace how mount paths are evaluated. Verify the behavior for PV paths beneath a non-mounted /mnt while unrelated filesystem metrics remain filtered; the issue does not name a file or test.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, prometheus
Domain
observability-sre
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.