prometheus / prometheus/node_exporter
Add Netstat IpInHdrErrors and IpInAddrErrors to default fields
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.8k
- Forks
- 2.7k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 8
Description
Host operating system: output of uname -a
Linux ip-10-200-110-160.node.domain 4.14.146-119.123.amzn2.x86_64
node_exporter version: output of node_exporter --version
1.18.0
node_exporter command line flags
Are you running node_exporter in Docker?
Yes
What did you do that produced an error?
It's just a default behaviour
What did you expect to see?
IpInHdrErrors and IpInAddrErrors metrics in netstat collector
What did you see instead?
No those metrics
--
The default netstat fields regexp: ^(.*_(InErrors|InErrs)|Ip_Forwarding|Ip(6|Ext)_(InOctets|OutOctets)|Icmp6?_(InMsgs|OutMsgs)|TcpExt_(Listen.*|Syncookies.*|TCPSynRetrans)|Tcp_(ActiveOpens|InSegs|OutSegs|PassiveOpens|RetransSegs|CurrEstab)|Udp6?_(InDatagrams|OutDatagrams|NoPorts))$
Doesn't cover two important IP stats about errors that lead to missing packages: IpInHdrErrors and IpInAddrErrors
What do you think about adding those to the default regexp?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the netstat collector's default fields regexp shown in the issue and confirm how selected fields become exported metrics. Include IpInHdrErrors and IpInAddrErrors in that selection, then verify that both metrics appear in the netstat collector output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, linux
- Domain
- networking, observability, operating-systems
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100