prometheus / prometheus/node_exporter
Add filter flag to mountstats
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.8k
- Forks
- 2.7k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 8
Description
node_exporter version: output of node_exporter --version
0.18.1
node_exporter command line flags
--collector.mountstats
Feature proposal
When mounting the same export multiple times the metrics are duplicated for each virtual mountpoint. There doesn't seem to be an easy method to de-duplicate this by understanding the underlying NFS client connection.
A simple workaround would be to add a manual ignore filter based on the export label. This would allow for exporter-side filtering of metrics. It may also be useful in other situations where only some NFS mountstats metrics are desired.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the mountstats collector behind the --collector.mountstats flag and trace how the export label is produced. Review existing flag and collector tests if available. Done means a manual export-based ignore filter can be configured and prevents matching mountstats metrics from being exposed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, prometheus
- Domain
- cli, observability-sre
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100