prometheus / prometheus/node_exporter
smartmon.py ignore raw value
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.8k
- Forks
- 2.7k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 8
Description
Host operating system: output of uname -a
Linux 4.15.0-46-generic #49-Ubuntu SMP Wed Feb 6 09:33:07 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
node_exporter version: output of node_exporter --version
commit 2f87b7cba6d6eb729a78724335fd59e746fcdff4
Hi,
I'm testing the text_collector_examples/smartmon.py script. It ignores those smartmon values, where the raw value is important.
E.g.
smartctl -a /dev/sda outputs
...
9 Power_On_Hours 0x0032 100 100 000 Old_age Always - 9306
...
where 9306 is the important information. smartmon.py just gives
smartmon_attr_threshold{name="power_on_hours",disk="/dev/sda"} 0
smartmon_attr_value{name="power_on_hours",disk="/dev/sda"} 100
smartmon_attr_worst{name="power_on_hours",disk="/dev/sda"} 100
which is useless.
smartmon.sh is better.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with text_collector_examples/smartmon.py and compare its parsing and emitted metrics with smartmon.sh. Reproduce the smartctl -a /dev/sda example, then verify that the raw attribute value such as 9306 is exposed rather than only threshold, value, and worst metrics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, shell
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100