prometheus / prometheus/node_exporter

Panic and crash when supervisord collector enabled, yet supervisord not listening on 127.0.0.1:9001

Open
#1,007 17 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
13.8k
Forks
2.7k
Avg merge
1d 23h
Merged PRs (30d)
8

Description

Host operating system: output of uname -a

Linux example.com 4.14.26-54.32.amzn2.x86_64 #1 SMP Tue Mar 27 21:50:30 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

node_exporter version: output of node_exporter --version
node_exporter, version 0.16.0 (branch: HEAD, revision: d42bd70f4363dced6b77d8fc311ea57b63387e4f)
  build user:       root@a67a9bc13a69
  build date:       20180515-15:52:42
  go version:       go1.9.6
node_exporter command line flags

./node_exporter-0.16.0.linux-amd64/node_exporter --collector.textfile.directory=/etc/prometheus/node_exporter --collector.supervisord

Are you running node_exporter in Docker?

No.

What did you do that produced an error?

Starting the node_exporter with --collector.supervisord enabled while supervisord isn't listening on 127.0.0.1:9001.

What did you expect to see?

To see an error, but for node_exporter to keep on running.

What did you see instead?

node_exporter panicking with this output.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure by starting node_exporter with --collector.supervisord while supervisord is not listening on 127.0.0.1:9001, and inspect the supervisord collector entry point and linked panic output. Done means node_exporter reports the connection error without panicking and continues running with the collector enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability-sre
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.