exposition format: How to deal with duplicate metric families
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 717
- Forks
- 1.2k
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 19
Description
The current spec is crystal clear that duplicate metric families (and, correspondingly, multiple TYPE and HELP lines for the same metric name in the text format) are not allowed in a single exposition.
However, the federation endopint of the prometheus server is currently in breach of that, see. https://github.com/prometheus/prometheus/issues/1963 .
This issue is about whether we should allow duplicate metric families, and if yes, how to deal with them.
(Problematic right now is that the Prometheus server tolerates them if ingesting protobuf, and just ingests them one after another, while it rejects any text format exposition with multiple TYPE or HELP lines for the same metric name.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the exposition-format specification and the linked Prometheus issue about federation output. The issue names no files or tests; determine whether duplicate metric families should be permitted and, if so, document the intended handling and update the relevant specification.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100