Having to sign the DCO discourages contributions
@hdost is already working on this.
Since Jun 14, 2022.
- Dominant language
- TypeScript
- Stars
- 717
- Forks
- 1.2k
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 19
Description
Background:
- I'm a technical writer, and love to contribute to open source projects on GitHub, given its easy to use interface for editing Markdown and submitting a PR.
- At the same time, I don't have the inclination to fork, clone, edit etc. a project just to fix a typo.
- Prometheus is the first project I've seen in years that automatically rejects all such contributions because of a thing called DCO (remember, I'm just a technical writer, and I'm unfamiliar with the reasons why this DCO is necessary here, but nowhere else I've been contributing).
- I'm not the only one whose commits have been rejected for not signing the DCO. https://github.com/prometheus/docs/search?q=dco&type=issues shows 116 issues that have the word "DCO" in them. Just look at the first page of results.
I assume this DCO thing is worth rejecting contributions from the community, but there's got to be a better way.
The PR template is super cryptic for drive-by contributors: "Please sign CNCF's Developer Certificate of Origin". What's CNCF? Developer Certificate of Origin? Yeah, you can Google those, but the whole line made me gloss over it several times, and the vast majority won't take the time to Google these things. Also, this line suggests that the contributor would have to "sign" something like a CLA, which can be done after submitting the commit, and is far more likely to be done than someone forking the repo, clonig, and amending their commit.
Also, the PR template is displayed too late for GitHub users. At that point, the commit was already made. Again, look at the hundreds of issues created by the DCO.
If you want to accept contributions from the community, please try to make it as easy as possible for the community to do so.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.