prometheus / prometheus/common
Silence model in common is out of sync with Alertmanager
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 295
- Forks
- 367
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 18
Description
The struct definition for a Silence in common/model is out of sync with the definition in alertmanager/types, for example common/model defines the ID field as a uin64 whereas it is now a string in alertmanager/types
Perhaps as Silences are only used in Alertmanager and not Prometheus the definition should be removed from common/model?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the Silence definitions in common/model and alertmanager/types, beginning with the differing ID field and checking the other fields for drift. Decide whether common/model should be synchronized or removed, then confirm the chosen change leaves the two projects' Silence representation consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100