prometheus / prometheus/common
Move Matchers from github.com/prometheus/prometheus/model/labels to common
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 295
- Forks
- 367
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 18
Description
Prometheus has Matcher and FastRegexMatcher.
Alertmanager currently uses an old fork of the label Matcher https://github.com/prometheus/alertmanager/pull/2009
So I'm suggesting we move these matchers to common and point both Prometheus and Alertmanager to common.
Alertmanager can especially benefit from the new FastRegexMatcher.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing Matcher and FastRegexMatcher in github.com/prometheus/prometheus/model/labels and the Alertmanager fork described in pull request 2009. Trace how Prometheus and Alertmanager currently use these types; done means the matchers live in common and both projects point to that shared implementation, including Alertmanager's FastRegexMatcher use.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100