prometheus / prometheus/common
toSecret' "return nil, nil" is error-prone
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 295
- Forks
- 367
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 18
Description
because the error is nil, we may/would be moving nils around, leading to nil pointer dereference
may be the cause of https://github.com/prometheus/prometheus/issues/16622
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in config/http_config.go at lines 781-797 and trace the callers of toSecret to understand how its nil return and nil error are handled. Review the linked Prometheus issue for the reported nil pointer dereference, then confirm the completed change prevents that failure and is covered by an appropriate regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100