prometheus / prometheus/common
NULL character on k8s zone labels
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 295
- Forks
- 367
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 18
Description
A related issue was opened some time ago https://github.com/kubernetes/kubernetes/issues/73867
This https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-helpers/node/topology/helpers.go#L57 adds the NULL character and then because in prometheus %q is used to print the value https://github.com/prometheus/common/blob/main/model/metric.go#L62 the character is printed.
If it makes sense to you I can open a PR to strip these characters from the label values.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review prometheus/common/model/metric.go around line 62, where the label value is printed with %q, and compare the behavior with the linked Kubernetes issue. Confirm whether NULL characters should be removed from label values; done means the reported character no longer appears in the resulting label output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100