prometheus / prometheus/common
Unmarshal URL's with urls.redacted
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 295
- Forks
- 367
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 18
Description
I propose that since go 1.15 supports url.Redacted, we make used of it while unmarshaling urls.
This could be done my adding a URL wrapper in this repo.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by locating the URL unmarshaling code in this Go repository and review Go 1.15's url.Redacted behavior and the linked upstream discussion; done should mean unmarshaled URLs use a wrapper that preserves the intended redaction behavior, with tests demonstrating it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100