prometheus / prometheus/client_rust

Implement Atomic for usize

Open
#193 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
606
Forks
113
Avg merge
9h 7m
Merged PRs (30d)
8

Description

I want to store usize in a gauge metric without conveting it to u64, but Atomic trait is not implemented for usize:
https://docs.rs/prometheus-client/0.22.2/prometheus_client/metrics/gauge/trait.Atomic.html

Because of this Gauge::<usize, AtomicUsize>::default(). Is there any reason for not supporting it? Would it require too high MSRV?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Atomic trait documentation linked in the issue and the Gauge::<usize, AtomicUsize>::default() usage described there. Check the project's MSRV and existing Atomic implementations to determine whether usize can be supported. Done means usize can be stored in a gauge without conversion and the relevant checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.