prometheus / prometheus/client_java

: does not get converted to _

Open
#1,548 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale
Dominant language
Java
Stars
2.3k
Forks
833
Avg merge
2d 16h
Merged PRs (30d)
86

Description

From @shakuzen in https://github.com/micrometer-metrics/micrometer/pull/6644#issuecomment-3203934641:

it seems : does not get converted to _ in 1.4.1 but it did in 1.3.10. Is that change intentional?

This breaks the Micrometer build, see https://github.com/micrometer-metrics/micrometer/pull/6644 and https://github.com/micrometer-metrics/micrometer/pull/6644#issuecomment-3203934641 for more details and reproducing tests.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Micrometer pull request #6644 and its reproducing tests, then compare the name-conversion behavior between versions 1.3.10 and 1.4.1. Done means determining whether the regression is intentional and ensuring that : is converted to _ as expected by the Micrometer build.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability-sre
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.