prometheus / prometheus/alertmanager

Review integrations code for consistency

Open
#4,726 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/notify keepalive
Dominant language
Go
Stars
8.6k
Forks
2.5k
Avg merge
2d 6h
Merged PRs (30d)
61

Description

Example: use payload instead of request:

// payload is the payload sent to mattermost's incoming webhook API.
// https://developers.mattermost.com/integrate/webhooks/incoming/#parameters
type payload struct {

Originally posted by @siavashs in https://github.com/prometheus/alertmanager/pull/4090#discussion_r2487548905

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file or test; begin by locating the integrations code and reviewing the Mattermost webhook example in the issue. Compare naming and comments across the integrations, then confirm that the consistency changes are complete with the relevant existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.