prometheus / prometheus/alertmanager
Ensure same timestamp context for all evaluations
Open
Nobody has claimed this yet.
component/notify
kind/enhancement
- Dominant language
- Go
- Stars
- 8.6k
- Forks
- 2.5k
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 61
Description
Currently we pass a now timestamp to the notification pipeline so all evaluations run against the same timestamp. This avoids artifacts. In some places we are not using that context timestamp yet but call time.Now() directly.
model.Alert.Resolved()types.Silence.Mutes()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the notification pipeline's now context into model.Alert.Resolved() and types.Silence.Mutes(), then inspect where those functions call time.Now(). Done means both evaluations use the provided context timestamp consistently and relevant evaluation behavior remains covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability-sre
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100