prometheus / prometheus/alertmanager

When there is a problem with one of the mailboxes, just skip it

Open
#3,496 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Go
Stars
8.6k
Forks
2.5k
Avg merge
2d 6h
Merged PRs (30d)
61

Description

What did you do?
When I set up multiple mailboxes, if there is a problem with one of the mailboxes, the logic here will reject the sending of notifications from all other normal mailboxes. Is this reasonable? Is it possible to skip the mailbox in question?

// notify/email/email.go
// Notify implements the Notifier interface.
func (n *Email) Notify(ctx context.Context, as ...*types.Alert) (bool, error) {
... ...
	for _, addr := range addrs {
		if err = c.Rcpt(addr.Address); err != nil {
			return true, errors.Wrapf(err, "send RCPT command")
		}
	}
... ...

What did you expect to see?
skip the email which has problem, and send messages to other normal emails

What did you see instead? Under which circumstances?
it will skip all emails.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in notify/email/email.go at Email.Notify, especially the loop calling c.Rcpt for each address. Confirm how a failed mailbox currently stops notification delivery; done means the problematic mailbox is skipped while messages still reach the other valid addresses.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.