prometheus / prometheus/alertmanager
Silences post returns a status code of 200 on create or update
Open
Nobody has claimed this yet.
component/api
stale
- Dominant language
- Go
- Stars
- 8.6k
- Forks
- 2.5k
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 61
Description
The silences POST endpoint returns a status code of 200 in all cases. No matter if it was an update or a create - semantically this feels wrong, I think we should return 201 when the silence was created or 200 when the silence was updated.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the silences POST endpoint and trace how it distinguishes creating a silence from updating one. Verify the endpoint returns 201 for a newly created silence and 200 for an update, then run the relevant API tests if they are available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100