prometheus / prometheus/alertmanager

Add a metric with alertmanager_notifications_success_total

Open
#2,913 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
8.6k
Forks
2.5k
Avg merge
2d 6h
Merged PRs (30d)
61

Description

What did you do?

I would like to create an availability SLO using (good events)/(total_events) and currently, we don't have a proper way to check what was the notification that was sent with success.

With that in mind, it could be nice to have a alertmanager_notifications_success_total metric, since alertmanager already has alertmanager_notifications_total and alertmanager_notifications_failed_total

What did you expect to see?

A way to identify alerts that was sent with success.

What did you see instead? Under which circumstances?

N/A

Environment

  • System information:

    N/A

  • Alertmanager version:

    0.24.0

  • Prometheus version:
    N/A

  • Alertmanager configuration file:
    N/A

  • Prometheus configuration file:
    N/A

  • Logs:
    N/A

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing alertmanager_notifications_total and alertmanager_notifications_failed_total metrics in the Alertmanager code and their tests. Check how notification outcomes are recorded, then add coverage for the requested success metric and verify it supports identifying successfully sent notifications.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, prometheus
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.