prometheus / prometheus/alertmanager
Improve actor lifecycle / shutdown management in main.go
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 8.6k
- Forks
- 2.5k
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 61
Description
See https://github.com/prometheus/alertmanager/pull/2897#pullrequestreview-959181763. There are currently some actors / goroutines that are shut down upon exit via the stopc channel, but some others (like mem.Alerts) are shut down differently, and yet others (like the Dispatcher) aren't shut down properly at all. This could be made more consistent.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in main.go and review the discussion in PR 2897, then trace the shutdown paths using stopc, mem.Alerts, and Dispatcher as the named examples. Done means the actor and goroutine shutdown behavior is made consistent across these cases, with no actors left improperly shut down.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100