prometheus / prometheus/alertmanager

Clustering: remove failed peers that are not in the configuration

Open
#2,775 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/high availability stale
Dominant language
Go
Stars
8.6k
Forks
2.5k
Avg merge
2d 6h
Merged PRs (30d)
61

Description

I was playing around with the alertmanager on Kubernetes using DNS service discovery and got some errors after updating my deployment that old peers couldn't be found anymore.

I was wondering if there is any specific reason why we would want to retry failed peers that are not part of the configuration or service discovery anymore? Should we perhaps remove them on refresh?

I'm aware of the configuration for the reconnect timeout/interval.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is identified in the issue. Start by locating the clustering refresh path that handles failed peers and compare it with configuration or service-discovery membership; done means peers no longer in current membership are removed without breaking reconnect behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems, observability-sre
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.