prometheus / prometheus/alertmanager

Expired silences are not garbage collected after --data.retention has passed

Open
#2,164 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/silences kind/more-info-needed stale
Dominant language
Go
Stars
8.6k
Forks
2.5k
Avg merge
2d 6h
Merged PRs (30d)
61

Description

What did you do?
Start alertmanager by alertmanager --config.file=./alertmanager.yml --storage.path=./data --data.retention=1h

What did you expect to see?
After 1 hour, the expired silences all disappear.
What did you see instead? Under which circumstances?
The expired silences all still there.
Environment
linux mechine

  • System information:

Linux 3.10.0-693.2.2.el7.x86_64 x86_64

  • Alertmanager version:

alertmanager, version 0.16.0 (branch: HEAD, revision: 73bdd966e0055f3b828340ade3ef1f3a38169cdc)
build user: root@fbea1f55d584
build date: 20190121-12:58:06
go version: go1.11.4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the shown alertmanager command and a 1h data retention setting. Trace the silence storage and expiration cleanup path, then verify that expired silences are removed after retention; add regression coverage if the repository has tests for this path.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.