prometheus-community / prometheus-community/stackdriver_exporter
RFC: collect stackdriver metrics globally and include them with the process metrics
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 295
- Forks
- 117
- Avg merge
- 9d 14h
- Merged PRs (30d)
- 7
Description
Context in #173.
@SuperQ we are quite close to a single deployment design where we pass filter params to the scrape endpoint.
However, when using this approach the innerHandler registers process scoped metrics (e.g: stackdriver_monitoring_api_calls_total) with the throwaway registry. These are not globally cumulative and they get reset with each scrape.
We would need these to be globally cumulative and (preferably only) available with the process metrics.
What do you think of these changes ?
I have time to work on this this week.
RFC:
- Should the stackdriver scrape endpoint still include these metrics ? If not this is a breaking change.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the context in #173 and inspect innerHandler, the throwaway registry, and the process metrics path. Clarify the RFC decision about whether the Stackdriver scrape endpoint should include these metrics, then define how global cumulative behavior will be verified without resetting on each scrape.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, google-cloud, prometheus
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100