prometheus-community / prometheus-community/postgres_exporter

Clearer error messages for multi target

Open
#742 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
3.6k
Forks
835
Avg merge
2d 4h
Merged PRs (30d)
10

Description

Below was the only clear part of the error logs that our setup of multi target mode wasn't setup properly:
ts=2023-01-06T21:29:18.433Z caller=probe.go:42 level=info msg="no auth_module specified, using default"

It would also say that "pq: password authentication failed for user \"nobody\"". While this is partially nice, it would be amazing if the error logs could yell saying that we have to use an auth_module for the probing setup.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at probe.go:42, where the multi-target setup currently reports that no auth_module was specified, and trace how probing authentication errors are logged. Reproduce the multi-target setup described in the issue and make the resulting logs clearly direct users to configure an auth_module; verify the PostgreSQL authentication failure remains understandable.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, postgresql
Domain
authentication, observability-sre
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.