prometheus-community / prometheus-community/postgres_exporter
Allow to add custom container command line arguments
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.6k
- Forks
- 835
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 10
Description
Proposal
Allow to add custom container command line arguments
Add extraArgs: [] to helm-chart values.yaml and include values to container args in templates/deployment.yaml
Use case
We need to access collector.database(=false) as the query within PGDatabaseCollector.Update method raises errors due to insufficient permissions for one of many databases. We use a managed DB and cannot change the permissions there.
We would be willing to create a PR if this feature seems sensible.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review values.yaml and templates/deployment.yaml in the Helm chart. Start by tracing how container arguments are currently defined, then confirm how the proposed extraArgs values should be included. Done means the chart accepts extraArgs and renders them as container arguments for the deployment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, postgresql
- Domain
- databases, devops
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100