prometheus-community / prometheus-community/postgres_exporter
error: unexpected true
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.6k
- Forks
- 835
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 10
Description
What did you do?
"--disable-default-metrics", "true",
What did you expect to see?
Disabled default metrics
It seems documentation contains wrong info:
disable-settings-metrics Use the flag if you don't want to scrape pg_settings. Default is false.
This is a flag. Flags do not have values.
Seems, it should be something like: scrape_pg_settings. Default is true
What did you see instead? Under which circumstances?
Error about "true" parameter
Environment
- System information: docker compose
- postgres_exporter version: 12.0
- postgres_exporter flags:
"--disable-default-metrics", "true"
"--disable-default-metrics", "true",
- PostgreSQL version: 15.0.0
- Logs:
postgres_exporter: error: unexpected true, try --help
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the flags section of the postgres_exporter README at the linked documentation page and compare the documented disable-default-metrics usage with the reported error. Correct the flag description and example so they match the actual flag syntax, then verify that the documentation no longer instructs users to pass an unexpected value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, postgres
- Domain
- documentation, observability
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100