prometheus-community / prometheus-community/postgres_exporter
short_version has wrong value for v10+
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.6k
- Forks
- 835
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 10
Description
I understand that this (11.6.0, i.e the .0 at the end) is mandated by semver, but then maybe it's time to ditch that and use something else. AFAIK semver assumed the 6 is the minor version while in fact it is the patch version for version 10 and up. Displaying short_version in dashboards (like in https://grafana.com/grafana/dashboards/6742 and more specifically https://grafana.com/api/dashboards/6742/images/4318/thumbnail) is pretty common, and displaying a (albeit only slightly, but still) wrong version is jarring.
Please excuse me if this issue was brought up and rejected before, but I couldn't find it while searching through the issues.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating where the postgres_exporter exposes short_version and compare its output for pre-v10 and v10+ versions. The issue names Grafana dashboard 6742 as a visible consumer, but no source file or test is identified; done requires an agreed version representation and regression coverage for the corrected value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, postgresql
- Domain
- databases, observability
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100