prometheus-community / prometheus-community/PushProx
Allow client to scrape a custom target while advertising a different FQDN
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 811
- Forks
- 154
- PR merge metrics
- No merged PRs in 30d
Description
In some situations I have encoutered it would be very helpful to advertise a given FQDN while targeting a hostname different from such FQDN.
One situation in which I would find this quite helpful is having to scrape multiple environment through a common PushProx proxy instance. If those environments are basically clones (e.g.: they are created via docker-compose and PushProx client itself is running inside a container) I end up havin to expose via --fqdn the same hostname (i.e.: node-exporter) for many instances which, in turn, leads to clashes at proxy component level.
In this case it would be nice to be able to provide a --target=node-exporter flag at client level that along with a different --fqdn for each environment (e.g.: --fqdn=dev.foo.com, --fqdn=qa1.foo.com, --fqdn=qa2.foo.com) would allow to point to the same proxy.
I put together a PR for this: #80.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the PushProx client option handling for --fqdn and review PR #80, which already proposes this behavior. Verify that a separate --target value is used for scraping while each client advertises its configured FQDN, and confirm the proxy can distinguish the environments without hostname clashes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, networking
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100