prometheus-community / prometheus-community/PushProx
Allow override of metrics URL in client for security
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 811
- Forks
- 154
- PR merge metrics
- No merged PRs in 30d
Description
Some use cases require being able to protect against a bad actor on the proxy side. E.G. someone with access to the proxy could send valid yet malicious requests through the client, defeating the purpose of the network barrier.
For example, if I run node-exporter and mysql on the same machine, running the client on that machine would allow access to mysql by a compromised prometheus environment. I think many people's security requirements won't allow that.
How do you feel about a patch that adds a backwards compatible --override-url option to the client?
#41 has no feedback, thus creating this issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PushProx client entry point and its existing URL and command-line option handling; issue #41 may provide related context. Define the backwards-compatible behavior of an --override-url option, including how it affects the metrics URL, and verify that clients without the option continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100