prometheus-community / prometheus-community/PushProx
PushProx is using fqdn.get() which is deprecated
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 811
- Forks
- 154
- PR merge metrics
- No merged PRs in 30d
Description
fqdn.Get() is deprecated
https://github.com/Showmax/go-fqdn/blob/869ae776d5881666b8e89ff9f536176ef1736658/legacy.go#L16
yet PushProx uses this function
The replacement method to use is fqdn.FqdnHostname()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open cmd/client/main.go and inspect the fqdn call around line 45. Confirm the current go-fqdn API and replace the deprecated call with fqdn.FqdnHostname(). Done means PushProx no longer uses the deprecated method and the relevant Go tests or build pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100