When in zoom and full screen preview maybe the background should be black like in WhatsApp and Element X on iOS and menus should not be shown when you stop zooming

Open
#934 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust

Research direction

Start with the full-screen image viewer and its iOS zoom, overlay, background, and orientation behavior, using the linked screen recording to reproduce the issues. Done means the conversation background stays hidden, controls remain hidden after zooming until tapped, and the image rotates correctly when returning from landscape to portrait.

Written by the indexing model from the issue text.

Description

For the Full screen viewer in Element X and WhatsApp you tap on the image twice. First to open from the preview and a second time open the full screen viewer (WhatsApp) or tap once to get the full screen view (Robrix and Element X).

But once there both WhatsApp and ElementX hides the underlying conversation thread (background is black).
And you can focus on the image.
Robrix is showing a bit of the background all the time.
And also let the on-screen menu be seen when you zoom back (file name in the bottom and the image editing buttons on the top).
The other apps keeps those things consistently hidden until you tap on the image to bring them forward, so you don't get the distraction

As soon as you let go of the zooming (2 finger) under iOS in Robrix these items are shown. It doesn't wait for the user to tap before being shown.

Link to Screen recording for Robrix: https://photos.app.goo.gl/t8cAnYbSTXDVUkVr9
Also note in the end as you go back from landscape to portrait the image fails to rotate back correctly

Finally note that in Element X you can use 2 finger zoom with the overlay of the file name on all time or tap once and hid the overlay while zooming

Dominant language
Rust
Stars
487
Forks
68
Avg merge
1h 22m
Merged PRs (30d)
54

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from project-robius/robrix

All issues in project-robius/robrix

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.