project-codeflare / project-codeflare/codeflare-sdk
Set PVC names in Ray ClusterConfig
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 35
- Forks
- 66
- Avg merge
- 48m
- Merged PRs (30d)
- 7
Description
Name of Feature or Improvement
I would like to be able to pass PVC names to a ClusterConfig.
Description of Problem the Feature Should Solve
When I create Ray clusters through the SDK, I couldn't find a way to add PVC name(s) to be added to the Ray object. I would like to be able to pass PVC names to a ClusterConfig instead of having to add that to a customized base template.
I am not using S3 endpoints, therefore that is not useful to me.
Describe the Solution You Would Like to See
Add persistent_volume_claims: List[str] to the ClusterConfig definition
Describe Alternatives You Have Considered
Copy https://github.com/project-codeflare/codeflare-sdk/blob/v0.19.0/src/codeflare_sdk/templates/base-template.yaml, edit and pass it through the template parameter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ClusterConfig definition and the rendering path for the Ray object, then compare it with templates/base-template.yaml from the referenced v0.19.0 SDK. Done means accepting persistent_volume_claims: List[str] in ClusterConfig and passing the supplied PVC names through to the generated Ray configuration without requiring a customized template.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kubernetes, python
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100