project-codeflare / project-codeflare/codeflare-sdk
ClusterConfiguration should support tolerations
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 35
- Forks
- 66
- Avg merge
- 48m
- Merged PRs (30d)
- 7
Description
ClusterConfiguration should support tolerations
Run Ray clusters (especially the worker pods) on tainted nodes.
Description of Problem the Feature Should Solve
You cannot create a Ray cluster with tolerations using the CodeFlare SDK
cluster = Cluster(ClusterConfiguration(...))
Often, machine nodes are tainted to prevent unwanted workloads. This is especially the case in GPU nodes which are often tainted. In addition different nodes will have different sized gpus, which would also use taints to make sure the correct workers land on the correct nodes.
You might also want to add a toleration to the headGroupSpec
Describe the Solution You Would Like to See
Add worker_tolerations and head_tolderations as optional parameters for ClusterConfiguration
cluster = Cluster(ClusterConfiguration(
head_tolerations=[key, operator, effect],
worker_tolerations=[key, operator, effect]
))
Describe Alternatives You Have Considered
Editing the yaml file and just using kuberay directly. You can currently manually edit an AppWrapper yaml to include a toleration for these taints.
workerGroupSpecs:
- spec:
tolerations:
- key: nvidia.com/gpu
operator: Exists
effect: NoSchedule
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ClusterConfiguration definition and the code that generates the KubeRay/AppWrapper YAML. Trace how workerGroupSpecs and headGroupSpec are built, then verify that optional tolerations appear in the requested pod specs using the existing configuration tests or generated YAML checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kubernetes, python
- Domain
- distributed-systems, infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100