project-codeflare / project-codeflare/codeflare-sdk

Several unit tests fail when user is connected to Kubernetes cluster which is not accessible

Open
#233 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
Python
Stars
35
Forks
66
Avg merge
48m
Merged PRs (30d)
7

Description

Following unit tests fail when the user is connected to kubernetes cluster which is not accessible:

  • tests/unit_test.py::test_ray_details
  • tests/unit_test.py::test_cluster_status
  • tests/unit_test.py::test_wait_ready

Unit tests pass successfully when user is not connected to kubernetes cluster (there is no "~/.kube/config") or if the user is connected to working Kubernetes cluster.

@Maxusmusti @MichaelClifford
I'm not sure if this is expected behavior or not. Because if I'm connected to the cluster which works properly then tests pass. But if I understand correctly unit tests should never connect to existing cluster. What do you think?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running tests/unit_test.py::test_ray_details, test_cluster_status, and test_wait_ready with an inaccessible Kubernetes cluster, then inspect how those tests discover cluster configuration. Done means the three tests pass consistently without depending on the user's existing Kubernetes connection, while still passing in the documented no-config and working-cluster cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes, python
Domain
infrastructure, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.